Skip to content

Update the python version used by GHA runners #1352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2025
Merged

Update the python version used by GHA runners #1352

merged 1 commit into from
Oct 22, 2025

Conversation

@a-maurice
Copy link
Collaborator

@a-maurice a-maurice commented Oct 22, 2025 •
edited
Loading

Description

Provide details of the change, and generalize the change in the PR title above.

Update the GHA runners to use Python 3.9. This is partially because of gcloud no longer working with 3.8

Testing

Describe how you've tested these changes.

https://github.com/firebase/firebase-unity-sdk/actions/runs/18728093413

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @a-maurice, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a critical infrastructure update, specifically upgrading the Python version used by GitHub Actions runners to 3.9. This change addresses compatibility issues with external tools like gcloud that no longer function correctly with Python 3.8, thereby ensuring the continued stability and functionality of the build and deployment processes.

Highlights

  • Python Version Update: The GitHub Actions (GHA) runners are being updated to utilize Python 3.9. This change is crucial as gcloud has encountered compatibility issues with Python 3.8, necessitating the upgrade.
  • Interpreter Search Order: The PythonExecutor.cs file has been modified to include python3.9 in the list of preferred Python interpreters, ensuring that the application can correctly locate and use the updated Python version.
Ignored Files
  • Ignored by pattern: .github/workflows/** (13)
    • .github/workflows/build-report.yml
    • .github/workflows/build_android.yml
    • .github/workflows/build_ios.yml
    • .github/workflows/build_linux.yml
    • .github/workflows/build_macos.yml
    • .github/workflows/build_starter.yml
    • .github/workflows/build_tvos.yml
    • .github/workflows/build_windows.yml
    • .github/workflows/generate_swig.yml
    • .github/workflows/integration_tests.yml
    • .github/workflows/package.yml
    • .github/workflows/retry-test-failures.yml
    • .github/workflows/update_versions.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

AustinBenoit
AustinBenoit approved these changes Oct 22, 2025
View reviewed changes
Copy link

@AustinBenoit AustinBenoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gemini-code-assist[bot]
gemini-code-assist bot reviewed Oct 22, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds python3.9 to the list of Python interpreters to be searched by GHA runners. This is a necessary update to support newer environments. I've added one comment suggesting a reordering of the interpreters list to make the version discovery more robust and ensure that newer, more specific versions are preferred.

editor/app/src/PythonExecutor.cs
// Just 'python' might prompt the user for input, so try that last
private static readonly string[] PYTHON_INTERPRETERS = {
"python3", "python3.8","python3.7", "python2.7", "python2", "python"
"python3", "python3.9", "python3.8","python3.7", "python2.7", "python2", "python"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The order of interpreters in this array is significant. By placing python3.9 after the generic python3, it's possible that an older version of Python (like 3.8) is picked up if python3 symlinks to it, even if python3.9 is available. To make the interpreter discovery more robust and align with the goal of using Python 3.9 when possible, it's better to list specific versions from newest to oldest before the generic python3 command.

          "python3.9", "python3.8", "python3.7", "python3", "python2.7", "python2", "python"

@a-maurice a-maurice merged commit a8b3db2 into main Oct 22, 2025
17 checks passed
@a-maurice a-maurice deleted the am-python_version branch October 22, 2025 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AustinBenoit AustinBenoit AustinBenoit approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@a-maurice @AustinBenoit